Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expand the DID scalar regex to accommodate did:pkh #1801

Merged
merged 2 commits into from
Mar 24, 2023

Conversation

mcclurejt
Copy link
Contributor

Description

did:pkh is a widely used method and should be captured by the regex

(issue #1800)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added test cases for a did:pkh string

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ardatan
Copy link
Collaborator

ardatan commented Mar 24, 2023

Thank you!

@ardatan ardatan merged commit 7337d43 into Urigo:master Mar 24, 2023
@theguild-bot theguild-bot mentioned this pull request Apr 24, 2023
37 tasks
@theguild-bot theguild-bot mentioned this pull request Oct 26, 2023
36 tasks
@theguild-bot theguild-bot mentioned this pull request Feb 5, 2024
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants