-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed a few bugs #2
Open
lorenzop
wants to merge
39
commits into
UrsusExplorans:master
Choose a base branch
from
lop-old:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also simplified the function
…IncomingChars() function
String(MAX_LENGTH) stores that number in the new string should be: String command = String();
I thought the pull request would only include the 4 initial commits I made at the time I submitted the pull request. it seems all my commits since then have also been included. let me know if you'd like to accept the pull request of all my changes or I can resubmit from a fresh fork if you want. I have made some awesome improvements and it's working great. more to come. |
or override with FORCE_ID define
finished digital and analog read functions
pins 0-1 are used for serial communication
use EEPROM.h for Uno and DueFlashStorage library for Due renamed MEM_ID define to MEMADDR_ID
added startup delay and id broadcast added VERSION define
combined OUTP and LOW commands changed _LOW command to LOW_ with optional _
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the file SerialControl.ino should be first caps, matching the folder name. probably not a problem for windows users, but does give an error on linux. I've tested the commands to be sure they all still work with these changes.
I also plan to add support for the ethernet shield, however I'm unsure if it's something you'd want, or just keep it for my own fork.