Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genral quality of life improvements to settings page #610

Merged
merged 8 commits into from
Apr 15, 2024

Conversation

chaosleader
Copy link
Contributor

I made a couple of small improvements to the settings page

  • I refactored the tab cloaking thing to store the tab cloak options as a object and added a clear custom cloak button
  • I switched weather to open in a about blank to be a switch
  • I made the escape key support multiple key strokes

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@IncognitoTGT
Copy link
Contributor

where's the object for cloaks?

@chaosleader
Copy link
Contributor Author

where's the object for cloaks?

its in main.js

its like this

  const options = {
    'Google': { name: 'Google', icon: '/assets/media/favicon/google.png' },
    'Drive': { name: 'My Drive - Google Drive', icon: '/assets/media/favicon/drive.png' },
    'Classroom': { name: 'Home', icon: '/assets/media/favicon/classroom.png' },
    'Schoology': { name: 'Home | Schoology', icon: '/assets/media/favicon/schoology.png' },
    ///other options
}

Copy link
Contributor

@IncognitoTGT IncognitoTGT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok yeah the diff didn't load
looks good to me

@xbubbo xbubbo merged commit 4ea4a72 into UseInterstellar:main Apr 15, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants