Inflection #48
Inflection #48
Conversation
src/Model/Endpoint.php
Outdated
| * | ||
| * @return null|string | ||
| */ | ||
| public function inflect($method = null) |
There was a problem hiding this comment.
inflectionMethod would be a better name. Currently the method name sounds as if it inflects string.
src/Model/Endpoint.php
Outdated
| @@ -453,6 +464,22 @@ public function resourceClass($name = null) | |||
| } | |||
|
|
|||
| /** | |||
| * Returns the inflect method or sets a new one | |||
| * | |||
| * @param null $method | |||
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
============================================
- Coverage 72.92% 71.94% -0.98%
- Complexity 359 363 +4
============================================
Files 13 13
Lines 890 916 +26
============================================
+ Hits 649 659 +10
- Misses 241 257 +16
Continue to review full report at Codecov.
|
|
The requested changes have been made. |
src/Model/Endpoint.php
Outdated
| * | ||
| * @var string | ||
| */ | ||
| protected $_inflection = 'underscore'; |
src/Model/Endpoint.php
Outdated
| @@ -153,6 +160,9 @@ public function __construct(array $config = []) | |||
| if (!empty($config['resourceClass'])) { | |||
| $this->resourceClass($config['resourceClass']); | |||
| } | |||
| if (!empty($config['inflection'])) { | |||
There was a problem hiding this comment.
Keep the option name inflect so that it's consistent with config name used in route builder.
There was a problem hiding this comment.
thanks for the clarification!
|
Wow, my first attempt at open-source contribution. Nice! thanks a lot!! |
|
Thank you for contributing. New release has been made which includes this change. |
This PR adds inflect option for generating endpoints.