Skip to content

Comments

Add piano-keys sounds#45

Merged
marceloams merged 1 commit intoUselessCo:developfrom
WinnyChang:add-piano-sounds
Oct 21, 2025
Merged

Add piano-keys sounds#45
marceloams merged 1 commit intoUselessCo:developfrom
WinnyChang:add-piano-sounds

Conversation

@WinnyChang
Copy link
Contributor

Pull Request

Type of Change

  • Bug fix
  • New feature
  • Sound contribution
  • Configuration contribution
  • Documentation update
  • Other (specify)

Description

Add piano key sounds ranging from C3 to E5, including both white and black keys.

Related Issue

Related to #2.

Changes Made

  • Created a new folder piano-keys under assets/sounds/.
  • Added 29 piano key sound files to the piano-keys folder.
    (Note: filenames for sharp keys use “s” instead of “#” due to kebab-case naming restrictions.)

For Sound Contributions

  • Sound is in MP3 format
  • File size is under 500KB
  • Added sound to assets/sounds/
  • Created/updated config that uses the sound

Audio

Audio samples were downloaded from this source, converted from .sf2 to .mp3, trimmed, faded out, and volume-adjusted.

Checklist

  • My code/contribution follows the project guidelines
  • I have tested my changes
  • I have updated documentation as needed
  • My changes don't break existing functionality

@marceloams marceloams merged commit 4f32eb3 into UselessCo:develop Oct 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants