Skip to content

Comments

Added cow moo sound#6

Merged
marceloams merged 3 commits intoUselessCo:developfrom
SEEDART007:cow-moo
Oct 13, 2025
Merged

Added cow moo sound#6
marceloams merged 3 commits intoUselessCo:developfrom
SEEDART007:cow-moo

Conversation

@SEEDART007
Copy link
Contributor

#2 Added cow moo sound

@marceloams
Copy link
Contributor

Hey @SEEDART007 ! I've simplified the docs to prevent PR conflicts. Could you remove the README changes from your PR? Also, remember to create/update a config to use your new sound, or do it in a separate PR after this merges. Thanks!

@marceloams
Copy link
Contributor

Hey @SEEDART007! Thanks for contributing!

I've removed the README changes since they're no longer needed (we changed our workflow to prevent conflicts).

However, your sound file isn't used in any config yet. You have two options:

  • Option 1: Add it to a config in this PR.
  • Option 2: I merge as-is, and you add the config later in a follow-up PR

Quick example if you want to add it now to src/configs/default.yaml:

- key: "4"
  sound: "../../assets/sounds/cow-moo.mp3"
  description: "Cow moo sound effect"

Which do you prefer? 🎵

@SEEDART007
Copy link
Contributor Author

Hey @SEEDART007! Thanks for contributing!

I've removed the README changes since they're no longer needed (we changed our workflow to prevent conflicts).

However, your sound file isn't used in any config yet. You have two options:

  • Option 1: Add it to a config in this PR.
  • Option 2: I merge as-is, and you add the config later in a follow-up PR

Quick example if you want to add it now to src/configs/default.yaml:

- key: "4"
  sound: "../../assets/sounds/cow-moo.mp3"
  description: "Cow moo sound effect"

Which do you prefer? 🎵

i'll add it later for now you can merge it ❤️

@marceloams
Copy link
Contributor

Got it @SEEDART007! Thanks for the contribution! 🎵

@marceloams marceloams merged commit 3231d6f into UselessCo:develop Oct 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants