Skip to content

Comments

Add memes config#8

Merged
marceloams merged 3 commits intoUselessCo:developfrom
aaryaparadkar:add-config-memes
Oct 13, 2025
Merged

Add memes config#8
marceloams merged 3 commits intoUselessCo:developfrom
aaryaparadkar:add-config-memes

Conversation

@aaryaparadkar
Copy link
Contributor

@aaryaparadkar aaryaparadkar commented Oct 13, 2025

Pull Request

Type of Change

  • Bug fix
  • New feature
  • Sound contribution
  • [ ✓ ] Configuration contribution
  • [ ✓ ] Documentation update
  • Other (specify)

Description

Added new memes configuration.

Changes Made

Added configuration.

For Sound Contributions

  • [ ✓ ] Sound is in MP3 format
  • [ ✓ ] File size is under 500KB
  • [ ✓ ] Added sound to assets/sounds/
  • [ ✓ ] Created/updated config that uses the sound

For Code Changes

  • Code follows project style
  • No console.log in production code
  • All imports have .js extensions
  • Tested locally
  • Updated documentation if needed

Screenshots/Audio

If applicable, add screenshots or audio samples (Optional: SoundCloud, YouTube, etc.).

Checklist

  • [ ✓ ] My code/contribution follows the project guidelines
  • [ ✓ ] I have tested my changes
  • [ ✓ ] I have updated documentation as needed
  • [ ✓ ] My changes don't break existing functionality

@marceloams
Copy link
Contributor

Hey @aaryaparadkar! There's a formatting error, please run npm run format to fix it and push a new commit. Thanks!

@aaryaparadkar
Copy link
Contributor Author

@marceloams done with the formatting on both branches, have a look and lmk if anything needs to be changing

@marceloams
Copy link
Contributor

@aaryaparadkar Could you please remove the pnpm-lock.yaml file from this PR? This is not necessary, since the project uses npm. I'll add it to .gitignore to prevent this in the future. Thanks!

@aaryaparadkar
Copy link
Contributor Author

sorry about that, completely forgot the file. removed it now, please have a look.

@marceloams marceloams merged commit be17089 into UselessCo:develop Oct 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants