fix: uptade how stfc email handler assign email templates

UserOfficeProject · Oct 31, 2022 · d897755 · d897755
1 parent 72fabfc
commit d897755
Showing 1 changed file with 5 additions and 13 deletions.
diff --git a/apps/user-office-backend/src/eventHandlers/email/stfcEmailHandler.ts b/apps/user-office-backend/src/eventHandlers/email/stfcEmailHandler.ts
@@ -51,24 +51,16 @@ export async function stfcEmailHandler(event: ApplicationEvent) {
 
         return;
       }
-
-      const instrument = instruments[0].name;
-
       let piEmailTemplate: string;
-
-      const isIsis = instrument === 'ISIS';
-
       const isRapidAccess =
-        isIsis && call?.shortCode?.toLowerCase().includes('rapid');
-
-      if (isIsis) {
-        piEmailTemplate = 'isis-proposal-submitted-pi';
-      } else if (isRapidAccess) {
-        piEmailTemplate = 'isis-rapid-proposal-submitted-pi';
+        call?.shortCode?.toLowerCase().includes('rapid') || false;
+      if (instruments[0].name === 'ISIS') {
+        piEmailTemplate = isRapidAccess
+          ? 'isis-rapid-proposal-submitted-pi'
+          : 'isis-proposal-submitted-pi';
       } else {
         piEmailTemplate = 'clf-proposal-submitted-pi';
       }
-
       const principalInvestigator = await userDataSource.getUser(
         event.proposal.proposerId
       );