Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a filter function for identifying Xpress call. #1109 #808

Merged
merged 18 commits into from
Oct 21, 2024

Conversation

bashanlam
Copy link
Contributor

Closes #
UserOfficeProject/issue-tracker#1109
UserOfficeProject/issue-tracker#1139

Description

Add a filter function for identifying Xpress call.

Motivation and Context

Add a filter function for identifying Xpress call.

How Has This Been Tested

Manually tested the filter function for identifying Xpress call.

Changes

Update backend function to add the new filter.

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@bashanlam bashanlam requested a review from a team as a code owner October 8, 2024 10:01
@bashanlam bashanlam requested review from bolmsten and mehta-pooja123 and removed request for a team October 8, 2024 10:01
@bashanlam bashanlam requested a review from mutambaraf October 14, 2024 09:59
Copy link
Contributor

@yoganandaness yoganandaness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

apps/backend/package-lock.json Outdated Show resolved Hide resolved
Copy link
Contributor

@yoganandaness yoganandaness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except the package-lock change.

@bashanlam bashanlam merged commit db02420 into develop Oct 21, 2024
19 checks passed
@bashanlam bashanlam deleted the 1109-Xpress-workflow branch October 21, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants