-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to export xpress proposals #834
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepaksftc
requested review from
RasmiaKulan,
mutambaraf,
a team,
martin-trajanovski and
yoganandaness
and removed request for
a team and
martin-trajanovski
October 30, 2024 14:23
mutambaraf
reviewed
Oct 30, 2024
mutambaraf
approved these changes
Oct 30, 2024
yoganandaness
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a feature that allows users to export Xpress proposals.
Motivation and Context
The need for this feature arose from the necessity to provide users with a way to export proposal data for offline usage and further analysis. This feature enhances the usability of the platform and provides additional value to our users.
Changes
DownloadService.ts
file.proposal.ts
file.xlsx.ts
file to handle the export of the collected data.xpress.cy.ts
file to ensure the feature works as expected.XpressProposalTable.tsx
file to include the export option in the UI.How Has This Been Tested
In addition to the unit tests that have been added, this feature has been manually tested to ensure its correct functionality. The e2e tests added in
xpress.cy.ts
confirm that an officer and a scientist can export proposals into Excel. The exported file was then manually inspected to ensure all data is present and correctly formatted.How Has This Been Tested?
Fixes Issue
UserOfficeProject/issue-tracker#1028
UserOfficeProject/issue-tracker#1205
Depends On
Tests included/Docs Updated?