chore: Upgrade apollo packages to prepare for gateway refactor #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-trajanovski
changed the title
…submitted field inside the call instruments query
martin-trajanovski
changed the title
martin-trajanovski
changed the title
martin-trajanovski
changed the title
martin-trajanovski
changed the title
martin-trajanovski
requested review from
mutambaraf and
jekabs-karklins
and removed request for
a team
jekabs-karklins
approved these changes
Jan 19, 2023
| }); | ||
| import { GraphQLScalarType, Kind } from 'graphql'; | ||
|
|
||
| export type AnswerType = number | string | Date | boolean | number[] | unknown; |
There was a problem hiding this comment.
Why is unknown needed here?
There was a problem hiding this comment.
It is needed after update of graphql. Most probably they changed the types and here is the result https://github.com/graphql/graphql-js/blob/main/src/type/definition.ts#L545. It is a bit disappointing because now the AnswerType is considered as unknown and the other types doesn't make much sense anymore.
mutambaraf
approved these changes
Jan 19, 2023
mutambaraf
reviewed
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is updating all the apollo packages to latest and moves the backend one step closer to upgrading gateway to version 2.
Motivation and Context
We were using quite old apollo packages and it is good to be up to date and improve functionality around it.
How Has This Been Tested
Fixes
https://jira.esss.lu.se/browse/SWAP-2770
Changes
Changes are mainly fixes after updating apollo packages