fix: generic template questions for cloned proposal #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutambaraf
requested review from
a team,
bashanlam and
bolmsten
and removed request for
a team
mutambaraf
requested review from
simonfernandes
and removed request for
a team
apps/user-office-frontend-e2e/cypress/integration/generic_templates.ts
Outdated
Show resolved
Hide resolved
apps/user-office-frontend-e2e/cypress/integration/generic_templates.ts
Outdated
Show resolved
Hide resolved
apps/user-office-frontend-e2e/cypress/integration/generic_templates.ts
Outdated
Show resolved
Hide resolved
apps/user-office-frontend-e2e/cypress/integration/generic_templates.ts
Outdated
Show resolved
Hide resolved
simonfernandes
approved these changes
Jan 31, 2023
RasmiaKulan
approved these changes
Feb 1, 2023
jekabs-karklins
approved these changes
Feb 8, 2023
mutambaraf
deleted the
763-fix-generic-template-questions-for-cloned-proposal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a user clone and update a proposal with generic sub templates the UI was clearing information in next steps on the proposal but information will still be in the database. This was being cause by generic template state update clearing information for next steps in the proposal.
Motivation and Context
When a user clone a proposal and then removed their sample(generic template), the old data was still present in the cloned proposal. This was affecting generic template type questions (samples, grants, publications).
How Has This Been Tested
Fixes
Closes: UserOfficeProject/issue-tracker#763
Changes
Files changed:
Depends on
Tests included/Docs Updated?