feat: add search by surname to proposal table #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffice-core into 913-add-search-by-name-and-email
…ffice-core into 913-add-search-by-name-and-email
…ffice-core into 913-add-search-by-name-and-email
ellen-wright
requested review from
EdwardHaynes
and removed request for
a team
|
We would also be interested in this feature at ELI. Thanks. |
EdwardHaynes
approved these changes
Sep 16, 2024
janosbabik
previously requested changes
Sep 30, 2024
There was a problem hiding this comment.
Hello @ellen-wright ,
I know this is still in draft, but I wanted to make sure you're aware that we should avoid using STFC-related data sources in the core.
2 tasks
mutambaraf
reviewed
Oct 10, 2024
mutambaraf
reviewed
Oct 10, 2024
…/UserOfficeProject/user-office-core into 913-add-search-by-name-and-email
mutambaraf
approved these changes
Oct 10, 2024
yoganandaness
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
@janosbabik Approving this, since the STFC Specific Data source has been removed to its own place.
@ellen-wright Looks good to me.
ellen-wright
dismissed
janosbabik’s stale review
Reviewed by another member of ESS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: UserOfficeProject/issue-tracker#913
Description
This PR adds the ability to search proposals by the surname of the PI.
Motivation and Context
Requested by Emma to make searching through proposal table easier.
How Has This Been Tested
Tested manually
Fixes
Changes
Added a call to UOWS to find user numbers for users with matching surname.
And filters proposal table by any proposals with the matching user number as PI.
Depends on
Tests included/Docs Updated?