Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing attributes for img tags in TinyMCE editors #764

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

gnyiri
Copy link
Collaborator

@gnyiri gnyiri commented Sep 13, 2024

Description

Image width/height attributes are removed from img tags in TinyMCE Rich Text answers (when images are allowed in template configuration).

Motivation and Context

Fix the issue described above.

How Has This Been Tested

Manual tests.

Fixes

Add missing attributes to the proper html sanitizer.

Changes

Add missing attributes to the proper html sanitizer.

Depends on

N/A

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@gnyiri gnyiri requested a review from a team as a code owner September 13, 2024 09:03
@gnyiri gnyiri requested review from ACLay and removed request for a team September 13, 2024 09:03
@gnyiri gnyiri merged commit 229fb24 into develop Sep 13, 2024
19 checks passed
@gnyiri gnyiri deleted the Add_Missing_Allowed_Attributes_For_Images branch September 13, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants