-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: optimised display of delete, archive, unarchive button #790
fix: optimised display of delete, archive, unarchive button #790
Conversation
Hi @yoganandaness! Nice fix! Could you cover it with an E2E test? |
c99703b
to
163d23a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have noticed that, you added a yarn.lock file to the project in this PR #748
Please remove it.
b74ff7e
to
c97ccf4
Compare
c97ccf4
to
87494db
Compare
@janosbabik i have removed the yarn.lock file. Could you please review it at your convenience. |
@yoganandaness It seems your new e2e tests are failing. |
d451096
to
7d079d8
Compare
@janosbabik the test is now passing. Could u pls approve. |
Description
This PR also contains the following fixs
Motivation and Context
Providing uniform experience for Delete, Archive and Unarchive button.
How Has This Been Tested
Manually
Fixes
Changes
Depends on
Tests included/Docs Updated?