Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimised display of delete, archive, unarchive button #790

Merged
merged 8 commits into from
Oct 29, 2024

Conversation

yoganandaness
Copy link
Contributor

@yoganandaness yoganandaness commented Sep 24, 2024

Description

  1. Delete button will be visible, if the template is not being used ie., not associated with any other dependencies
  2. Archive button will be visible, if the template is being used or not used
  3. Unarchive button will be visible, if the template is archived.

This PR also contains the following fixs

  1. In the Proposal template table, where the check for validating if the pdf template is being used by any calls was not correctly configured.
  2. Validating Deletion in ESI Template was incorrect. It was not validating if the ESI template is associated with any call or not. Validation added.
  3. Fap Review template Call count was calculated incorrectly. Fixed.

Motivation and Context

Providing uniform experience for Delete, Archive and Unarchive button.

How Has This Been Tested

Manually

Fixes

Changes

Depends on

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@yoganandaness yoganandaness requested a review from a team as a code owner September 24, 2024 10:40
@yoganandaness yoganandaness requested review from Bhaswati1148 and janosbabik and removed request for a team September 24, 2024 10:40
@yoganandaness yoganandaness changed the title optimised display of delete, archive, unarchive button. optimised display of delete, archive, unarchive button Sep 24, 2024
@yoganandaness yoganandaness changed the title optimised display of delete, archive, unarchive button fix: optimised display of delete, archive, unarchive button Sep 24, 2024
@janosbabik
Copy link
Contributor

Hi @yoganandaness! Nice fix! Could you cover it with an E2E test?

@yoganandaness yoganandaness force-pushed the SWAP-4208-uo-template-deletion-and-archival branch from c99703b to 163d23a Compare September 26, 2024 12:01
Copy link
Contributor

@janosbabik janosbabik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have noticed that, you added a yarn.lock file to the project in this PR #748
Please remove it.

@yoganandaness yoganandaness force-pushed the SWAP-4208-uo-template-deletion-and-archival branch from b74ff7e to c97ccf4 Compare October 14, 2024 19:15
@yoganandaness yoganandaness force-pushed the SWAP-4208-uo-template-deletion-and-archival branch from c97ccf4 to 87494db Compare October 14, 2024 19:16
@yoganandaness
Copy link
Contributor Author

@janosbabik i have removed the yarn.lock file. Could you please review it at your convenience.

@janosbabik
Copy link
Contributor

@yoganandaness It seems your new e2e tests are failing.

@yoganandaness yoganandaness force-pushed the SWAP-4208-uo-template-deletion-and-archival branch from d451096 to 7d079d8 Compare October 28, 2024 12:49
@yoganandaness
Copy link
Contributor Author

@yoganandaness It seems your new e2e tests are failing.

@janosbabik the test is now passing. Could u pls approve.

@yoganandaness yoganandaness merged commit 845ec87 into develop Oct 29, 2024
19 checks passed
@yoganandaness yoganandaness deleted the SWAP-4208-uo-template-deletion-and-archival branch October 29, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants