Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add internal review create/update/delete events to eli mail han… #804

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

gnyiri
Copy link
Collaborator

@gnyiri gnyiri commented Oct 4, 2024

Add internal review create/update/delete events to eli mail handler

Description

Add INTERNAL_REVIEW_CREATED, UPDATED, DELETED events to app events and eli email handler.

Motivation and Context

At ELI we would like to notify the internal reviewers on internal review changes.

How Has This Been Tested

Manual tests.

Fixes

N/A

Changes

eli mail handler, application events

Depends on

N/A

Tests included/Docs Updated?

  • [x ] I have added tests to cover my changes.
  • [ x] All relevant doc has been updated

@gnyiri gnyiri requested a review from a team as a code owner October 4, 2024 07:58
@gnyiri gnyiri requested review from mehta-pooja123 and removed request for a team October 4, 2024 07:58
@gnyiri gnyiri requested a review from ACLay October 7, 2024 16:45
Copy link
Contributor

@yoganandaness yoganandaness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@gnyiri gnyiri merged commit f2b7c0c into develop Oct 8, 2024
19 checks passed
@gnyiri gnyiri deleted the feat_add_new_eli_email_handler branch October 8, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants