feat: assign instruments to Xpress proposals #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepaksftc
requested review from
EdwardHaynes,
a team,
bolmsten,
simonfernandes and
mutambaraf
and removed request for
a team
deepaksftc
requested review from
a team and
Junjiequan
and removed request for
a team
janosbabik
requested review from
janosbabik
and removed request for
Junjiequan
simonfernandes
approved these changes
Oct 23, 2024
apps/backend/src/resolvers/mutations/AssignProposalsToInstrumentsMutation.ts
Outdated
Show resolved
Hide resolved
apps/backend/src/resolvers/mutations/AssignProposalsToInstrumentsMutation.ts
Outdated
Show resolved
Hide resolved
apps/backend/src/resolvers/mutations/AssignProposalsToInstrumentsMutation.ts
Show resolved
Hide resolved
simonfernandes
approved these changes
Oct 29, 2024
|
Hi @janosbabik, could you please have a look at this PR and suggest if there is any changes required. |
janosbabik
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces the feature of assigning instruments to Xpress proposals.
Motivation and Context
This change was required to provide the ability for users to assign specific instruments to Xpress proposals, enhancing the granularity and specificity of proposal handling.
Changes
checkProposalsHasTechniquesmethod inTechniqueDataSource,TechniqueDataSourceMock, andPostgresTechniqueDataSourceto verify if proposals have techniques.assignXpressProposalsToInstrumentsinInstrumentMutationsandAssignProposalsToInstrumentsMutationto assign instruments to proposals.AssignProposalsToInstrumentsMutationto validate if the proposals are Xpress before assigning instruments.xpress.cy.tsto verify the new functionality.XpressProposalTable.tsxto include the new feature of assigning instruments to proposals.How Has This Been Tested?
Fixes Issue
UserOfficeProject/issue-tracker#1137
Depends On
Tests included/Docs Updated?