feat: add setting for Xpress email recipients. #1297 #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashanlam
requested review from
simonfernandes,
mutambaraf,
deepaksftc and
a team
bashanlam
requested review from
Junjiequan and
ACLay
and removed request for
a team
ACLay
requested changes
Jan 22, 2025
added 2 commits
January 22, 2025 13:38
…:UserOfficeProject/user-office-core into 1297-Xpress-setting-for-email-recipients
| IF register_patch('0168_XpressEmailSetting.sql', 'Chi Kai Lam', 'Xpress email setting for recipients SAMPLE_SAFETY_EMAIL and TECHNIQUE_SCIENTISTS_EMAIL', '2025-01-13') THEN | ||
| BEGIN | ||
| INSERT INTO settings (settings_id, settings_value, description) VALUES ('SAMPLE_SAFETY_EMAIL', '', 'Email address for the sample safety.'); | ||
| INSERT INTO settings (settings_id, settings_value, description) VALUES ('TECHNIQUE_SCIENTISTS_EMAIL', '', 'Email address for the Xpress technique scientist.'); |
There was a problem hiding this comment.
I'm not sure how it will work to have technique scientists as a static setting. The email needs to be sent only to the scientists belonging to the technique the proposal is submitted to, and we don't know which technique that is until the proposal has been submitted. If the setting has every technique scientist in it, it would alert scientists in other techniques that don't care about the proposal (not to mention require us to maintain another list).
|
Hello @bashanlam , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
UserOfficeProject/issue-tracker#1297
Description
Add Xpress setting for email recipients.
Motivation and Context
Add Xpress setting for email recipients.
How Has This Been Tested
Manually tested Xpress setting for email recipients.
Changes
Insert record to Setting table for Xpress email recipients SAMPLE_SAFETY_EMAIL and TECHNIQUE_SCIENTISTS_EMAIL.
Update backend function for the Xpress email recipients.
Tests included/Docs Updated?