Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect mapping of meshes to blend shape bind mesh indices. #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ExpiredPopsicle
Copy link
Contributor

This was additionally causing issues adding surfaces inside adjust_mesh_zforward.

When attempting to add a surface, the mapping mismatch would cause the number of blend shapes to differ between the arrays being added and the mesh, which would cause the mesh.add_surface call to fail.

That failure to add a surface would then cause more issues in _create_animation_player.

…hich was causing issues adding surfaces inside adjust_mesh_zforward.
@fire
Copy link
Member

fire commented Dec 7, 2024

Can you provide an issue with a mrp?

@ExpiredPopsicle
Copy link
Contributor Author

Unfortunately, I do not have permission to share the model that was reproducing this.

@copygirl sent me the model, after getting permission from the original owner to share it.

I can try to generate a contrived case, but I'm not sure if the Blender VRM exporter I use is capable of creating a case of it from scratch.

@fire
Copy link
Member

fire commented Dec 8, 2024

Maybe we can contrive a smaller test case.

@copygirl
Copy link

copygirl commented Dec 8, 2024

From what I know, the model was just a basic VRoid Studio model, but may have been edited in Unity to re-parent the hair-based tail to the body, rather than the head?

Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People have been using SnekStudio with it for a bit now.

I wanted to make a testbank, but we never got the people to help out with it. So SnekStudio is doing more testing with shipping the addon than we are.

@fire fire requested a review from lyuma January 11, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants