Skip to content

Commit

Permalink
Merge pull request #1273 from V4Fire/dimeliora/page-meta-data-fix
Browse files Browse the repository at this point in the history
Fix pageMetaData
  • Loading branch information
Dimeliora authored May 20, 2024
2 parents a3b5eb9 + 00768f6 commit 4a8b30e
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/core/page-meta-data/class.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import { isAbsURL, concatURLs } from 'core/url';

import { ssrEngine, domEngine } from 'core/page-meta-data/elements/abstract/engines';
import { domTitleEngine } from 'core/page-meta-data/elements/title';
import { ssrTitleEngine, domTitleEngine } from 'core/page-meta-data/elements/title';

import Store from 'core/page-meta-data/store';

Expand Down Expand Up @@ -51,7 +51,7 @@ export class PageMetaData {
const attrs = {text: value};

const title = new Title(
SSR ? ssrEngine : domTitleEngine,
SSR ? ssrTitleEngine : domTitleEngine,
attrs
);

Expand Down
1 change: 1 addition & 0 deletions src/core/page-meta-data/elements/title/engines/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@
*/

export * from 'core/page-meta-data/elements/title/engines/dom';
export * from 'core/page-meta-data/elements/title/engines/ssr';
18 changes: 18 additions & 0 deletions src/core/page-meta-data/elements/title/engines/ssr/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
/*!
* V4Fire Client Core
* https://github.com/V4Fire/Client
*
* Released under the MIT license
* https://github.com/V4Fire/Client/blob/master/LICENSE
*/

import type { AbstractElement } from 'core/page-meta-data/elements';
import { SSREngine } from 'core/page-meta-data/elements/abstract/engines';

export class SSRTitleEngine extends SSREngine {
override render(_element: AbstractElement, tag: string, attrs: Dictionary<string>): string {
return `<${tag}>${attrs.text}</${tag}>`;
}
}

export const ssrTitleEngine = new SSRTitleEngine();
2 changes: 1 addition & 1 deletion src/core/page-meta-data/store/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export default class Store {
} else if (Object.isArray(val)) {
yield* val;

} else {
} else if (Object.isPlainObject(val)) {
yield* traverse(Object.values(val));
}
}
Expand Down

0 comments on commit 4a8b30e

Please sign in to comment.