Fix/router transition labels (#1300)

* fix(b-router): fixed route update prevention, caused by another transition method
V4Fire · Jun 11, 2024 · e79d8a0 · e79d8a0
1 parent 937f79d
commit e79d8a0
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,13 @@ Changelog
 
 _Note: Gaps between patch versions are faulty, broken or test releases._
 
+## v4.0.0-beta.102 (2024-06-11)
+
+#### :bug: Bug Fix
+
+* Removed the use of `$a.promise` in the `execute` method of the `Transition` class. This previously caused only
+the last `replace` method call to be executed when multiple calls were made `components/base/b-router`
+
 ## v4.0.0-beta.101 (2024-05-30)
 
 #### :bug: Bug Fix

diff --git a/src/components/base/b-router/CHANGELOG.md b/src/components/base/b-router/CHANGELOG.md
@@ -9,6 +9,13 @@ Changelog
 > - :house: [Internal]
 > - :nail_care: [Polish]
 
+## v4.0.0-beta.102 (2024-06-11)
+
+#### :bug: Bug Fix
+
+* Removed the use of `$a.promise` in the `execute` method of the `Transition` class. This previously caused only
+the last `replace` method call to be executed when multiple calls were made.
+
 ## v4.0.0-beta.97 (2024-05-21)
 
 #### :bug: Bug Fix

diff --git a/src/components/base/b-router/modules/transition/class.ts b/src/components/base/b-router/modules/transition/class.ts
@@ -156,7 +156,8 @@ export default class Transition {
  this.initNewRouteInfo();
 
  this.scroll.createSnapshot();
- await $a.promise(this.scroll.updateCurrentRouteScroll(), transitionLabel);
+ // FIXME: removing of $a.promise is a temporaty fix of https://github.com/V4Fire/Client/issues/1301
+ await this.scroll.updateCurrentRouteScroll();
 
  // We didn't find any route matching the given ref
  if (this.newRouteInfo == null) {