Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/router transition labels #1300

Merged
merged 7 commits into from
Jun 11, 2024
Merged

Fix/router transition labels #1300

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0522677
fix(b-router): fixed route update prevention, caused by another trans…
Jun 10, 2024
6dfbc29
fix(b-router): change label symbol name
Jun 10, 2024
c387439
fix(b-router): undo promise label on updateCurrentRouteScroll
Jun 10, 2024
59135a5
fix(b-router): add comments
Jun 10, 2024
ddf176e
fix(b-router): eslint fixes
Jun 10, 2024
59d3ebd
fix(b-router): CHANGELOG fix
Jun 10, 2024
0cecd77
:art: changelog
bonkalol Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/components/base/b-router/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ Changelog
> - :house: [Internal]
> - :nail_care: [Polish]

#### :bug: Bug Fix
kobezzza marked this conversation as resolved.
Show resolved Hide resolved

* Fixed a route update prevention, caused by new transition method call
kobezzza marked this conversation as resolved.
Show resolved Hide resolved

## v4.0.0-beta.97 (2024-05-21)

#### :bug: Bug Fix
Expand Down
2 changes: 1 addition & 1 deletion src/components/base/b-router/modules/transition/class.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@
this.initNewRouteInfo();

this.scroll.createSnapshot();
await $a.promise(this.scroll.updateCurrentRouteScroll(), transitionLabel);
await this.scroll.updateCurrentRouteScroll(); // Temporaty fix of https://github.com/V4Fire/Client/issues/1301

Check failure on line 159 in src/components/base/b-router/modules/transition/class.ts

View workflow job for this annotation

GitHub Actions / linters (20.x) 

Unexpected comment inline with code

Check failure on line 159 in src/components/base/b-router/modules/transition/class.ts

View workflow job for this annotation

GitHub Actions / linters (20.x) 

Expected comment to be above code

Check failure on line 159 in src/components/base/b-router/modules/transition/class.ts

View workflow job for this annotation

GitHub Actions / linters (20.x) 

Trailing spaces not allowed

Check failure on line 159 in src/components/base/b-router/modules/transition/class.ts

View workflow job for this annotation

GitHub Actions / linters (20.x) 

Unexpected comment inline with code

Check failure on line 159 in src/components/base/b-router/modules/transition/class.ts

View workflow job for this annotation

GitHub Actions / linters (20.x) 

Expected comment to be above code

Check failure on line 159 in src/components/base/b-router/modules/transition/class.ts

View workflow job for this annotation

GitHub Actions / linters (20.x) 

Trailing spaces not allowed
kobezzza marked this conversation as resolved.
Show resolved Hide resolved

// We didn't find any route matching the given ref
if (this.newRouteInfo == null) {
Expand Down
Loading