fix(cookies): maxAge param

CHANGELOG.md

@@ -11,6 +11,13 @@ Changelog
 
 _Note: Gaps between patch versions are faulty, broken or test releases._
 
+## v4.0.0-beta.?? (2024-07-??)
+
+#### :bug: Bug Fix
+
+* Corrected the improper conversion of cookie attributes that are passed in camelCase format:
+ now all are forcibly converted to dash-style `core/cookies`
+
 ## v4.0.0-beta.106 (2024-06-25)
 
 #### :bug: Bug Fix

src/core/cookies/CHANGELOG.md

@@ -9,6 +9,13 @@ Changelog
 > - :house: [Internal]
 > - :nail_care: [Polish]
 
+## v4.0.0-beta.?? (2024-07-??)
+
+#### :bug: Bug Fix
+
+* Corrected the improper conversion of cookie attributes that are passed in camelCase format:
+ now all are forcibly converted to dash-style
+
 ## v4.0.0-beta.62 (2024-02-19)
 
 #### :bug: Bug Fix

src/core/cookies/class.ts

@@ -71,7 +71,7 @@ export class Cookies {
  cookie = `${encodeURIComponent(name)}=${encodeURIComponent(value)}`;
 
  Object.entries(opts).forEach(([key, val]) => {
- cookie += `; ${key}`;
+ cookie += `; ${key.dasherize()}`;
 
  if (val !== true) {
  cookie += `=${val}`;

src/core/cookies/test/unit/main.ts

@@ -117,6 +117,28 @@ test.describe('core/cookies', () => {
  const cookies = await context.cookies(page.url());
  test.expect(cookies.filter((el) => el.name === 'testCookie')).toEqual([resolveCookieParams({expires})]);
  });
+
+ test('with the `maxAge` option provided', async () => {
+ await cookiesAPI.evaluate(
+ (cookies) => cookies.set('testCookie', 'testCookieVal', {maxAge: 10})
+ );
+
+ const res1 = await cookiesAPI.evaluate(
+ (cookies) => cookies.store.cookie
+ );
+
+ test.expect(res1.includes('testCookie=testCookieVal')).toBe(true);
+
+ await cookiesAPI.evaluate(
+ (cookies) => cookies.set('testCookie', 'testCookieVal', {maxAge: 0})
+ );
+
+ const res2 = await cookiesAPI.evaluate(
+ (cookies) => cookies.store.cookie
+ );
+
+ test.expect(res2.includes('testCookie=testCookieVal')).toBe(false);
+ });
  });
 
  test.describe('`remove`', () => {