-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speedup 3 1 #1438
Merged
Merged
Speedup 3 1 #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md # build/webpack/CHANGELOG.md
shining-mind
reviewed
Nov 9, 2024
Co-authored-by: Artem Shinkaruk <46344555+shining-mind@users.noreply.github.com>
* BREAKING_CHANGE: removed legacy `inheritMods` implementation * chore: new `sharedMods` API * chore: added caching for shared-mods * chore: improved sharedMods api * fix: don't provide redundant mods * chore: optimization * chore: optimization * chore: optimization * chore: optimization * chore: added memoization * Revert "chore: added memoization" This reverts commit e9b5f3f. * fix: fixed memoization * chore: optimized method creation * chore: reverted memoization * chore: implemented a smoother migration to `forceUpdate: false` props * Revert "chore: memoization of values in sharedMods" This reverts commit 8e752b0.
…nly with super, so it's not necessary to initialize them as a method on the component
# Conflicts: # CHANGELOG.md
shining-mind
approved these changes
Nov 14, 2024
# Conflicts: # CHANGELOG.md # src/core/component/decorators/CHANGELOG.md # src/core/component/decorators/factory.ts # src/core/component/decorators/prop/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.