ParseJson suddenly very slow

[rachid-adf]

Hello !!!

the sub ParseJson suddenly became very slow in one computer only (a recent one i7-7 Gen), I didn't change anything in the code, 3 minutes for a little json,

after test I noticed that this row of code takes a long time to execute (a couple of second for each iteration) :

json_CopyMemory ByVal json_UnsignedAdd(StrPtr(json_buffer), json_BufferPosition), ByVal StrPtr(json_Append), json_AppendLength

do you have an idea where this comes from?

[counterpoint1]

I believe I now have the exact same problem. It broke my process dependent on this converter. It must be one of these latest Excel 2017 updates that broke this. This is on Windows side.

It appears this pull request addresses the problem. Replaced the code with his code and used the provided clsStringAppend class and all is well again.
#82

[rachid-adf]

counterpoint1, thank you very much, your solution works very well!

[Locke]

Same here: suddenly a drastic performance regression. I could reproduce it on multiple machines running either Windows 10 1803 or 1709.

I also noticed that during the parsing the Windows Defender (MsMpEng.exe) consumes a full CPU (constant 12% on i7), while the CPU usage for WINWORD.exe remained zero.

Applying the mentioned PR resolves the regression.

[rachid-adf]

@Locke try with this, it works for me
https://github.com/PGS62/VBA-JSON/blob/0a88ffd8fd4a73ba58ba6b95cd463271062d0180/JsonConverter.bas

[Locke]

@rachid-adf That's what I meant with "Applying the mentioned PR resolves the regression" :)

[hlalibe]

Hi guys,
struggling here, not so familiar with Git
i've downloaded and installed the new JsonConverter.bas file
but now i have an error message on Dim cSA As New clsStringAppend -> Compile error - user defined type not defined.
Any guidance appreciated

[rachid-adf]

@hlalibe you have just to add the class clsStringAppend.cls in your project
https://github.com/PGS62/VBA-JSON/blob/master/clsStringAppend.cls

[hlalibe]

@rachid-adf
thanks Rachid. But how do i do this ? (sorry)
I have the file now , but i don't know what to do with it

[rachid-adf]

@hlalibe in your project insert a new Class Module from menu and copy the code into

[hlalibe]

ok got it,
but i had to comment out these 4 first lines to avoid compiling errors
VERSION 1.0 CLASS
BEGIN
MultiUse = -1 'True
END

[marcelmueller1978]

@rachid-adf
Thanks a lot for your solution!

[duncanelliot]

Hi There,

@rachid-adf @Locke Could you take a look at the link and let me know whether mine is the same problem as yours... I can't quite decide.

VBA-tools/VBA-Web#345

Thanks,

Duncan

[iamanubhavp]

Hey @rachid-adf, I've been getting "Compile error: Expected: end of statement", while running the class module code you've shared above.
Could you please help me on this ?

[rachid-adf]

Hi @iamanubhavp, juste delete all text before Option Explicit, and also delete the rows numbers

[iamanubhavp]

@rachid-adf, I already tried doing that. I think the issue here is with the way I'm running this code. I think I need to import the code .BAS & .cls file.
Is that correct ?

[timhall]

@iamanubhavp What version of VBA-JSON are you using? The clsStringAppend approach is part of v2.3.0 and later (you can download the latest version here: https://github.com/VBA-tools/VBA-JSON/releases/latest

[iamanubhavp]

Thanks @timhall , I resolved it by importing .bas & .cls files rather than copy/pasting the code into the modules.