Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1936 this fixes issues regarding memory alignment.
Here these issues can happen on any OS, I had the case where changing
Port
struct would lead to crashes due to how these were packed in a std::vector.SSE (and NEON) requires the data it accesses to be aligned, otherwise results in a crash (SIGBUS on ARM).
I guess Rack was lucky that
Port
contents are able to be packed together in a way that keeps SSE working.Same with #1936 please take these changes and do with them as you please.
I am here in written text giving you full rights to this patch / code changes.