Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bark #535

Open
Coirt opened this issue Jan 29, 2019 · 56 comments
Open

Bark #535

Coirt opened this issue Jan 29, 2019 · 56 comments
Labels

Comments

@Coirt
Copy link

Coirt commented Jan 29, 2019

Hi guys
Looking to add my modules to the plugin manager

URL: https://github.com/Coirt/Bark
License: BSD-4-Clause
Minifest: https://github.com/Coirt/Bark/blob/0.6.3/Bark.json

@cschol cschol added the plugin label Feb 2, 2019
@cschol
Copy link
Collaborator

cschol commented Feb 2, 2019

Build failure on Linux: Coirt/Bark#10

@Coirt
Copy link
Author

Coirt commented Feb 2, 2019

Updated make file there. Hows this look?

RACK_DIR ?= ../..
SLUG = Bark
VERSION = 0.6.3

FLAGS +=
SOURCES += $(wildcard src/*.cpp)
DISTRIBUTABLES += $(wildcard LICENSE*) res
# Include the VCV Rack plugin Makefile framework
include $(RACK_DIR)/plugin.mk

@cschol
Copy link
Collaborator

cschol commented Feb 2, 2019

Looking good. Thank you for fixing.

@cschol cschol closed this as completed Feb 2, 2019
@cschol cschol reopened this Feb 2, 2019
@Coirt
Copy link
Author

Coirt commented Feb 2, 2019

I'll get the whiskey so...

@AndrewBelt
Copy link
Member

Updated build

@Coirt
Copy link
Author

Coirt commented Feb 9, 2019

manifest update: https://github.com/Coirt/Bark/blob/0.6.3/Bark.json

Same version just added a donate link

"donateUrl": "https://www.paypal.me/philgolden",

@cschol cschol reopened this Feb 9, 2019
@cschol
Copy link
Collaborator

cschol commented Feb 10, 2019

Manifest is updated. Link is available on the Plugin website.

@cschol cschol closed this as completed Feb 10, 2019
@Coirt
Copy link
Author

Coirt commented Feb 18, 2019

Master now at v0.6.4

@AndrewBelt AndrewBelt reopened this Feb 18, 2019
@Coirt
Copy link
Author

Coirt commented Feb 18, 2019

Just rediscovered a bug I thought I had fixed.

EDIT:
Think I fixed it, so should be good to go as is.

Nah didn't fix it I have the trigger for the bug disabled, so as is!

@cschol
Copy link
Collaborator

cschol commented Feb 19, 2019

VERSION in Makefile needs to be updated to 0.6.4.

@Coirt
Copy link
Author

Coirt commented Feb 19, 2019

Makefile is 0.6.4. Thought I defaulted master to 0.6.4 seems not the case.

https://github.com/Coirt/Bark/tree/0.6.4

@Coirt
Copy link
Author

Coirt commented Feb 19, 2019

I'll try that again... Master now 0.6.4

@cschol
Copy link
Collaborator

cschol commented Feb 20, 2019

The Makefile in the 0.6.4 tag is still at 0.6.3. I am using the HEAD of master.

@AndrewBelt
Copy link
Member

Updated build

@Coirt
Copy link
Author

Coirt commented Feb 20, 2019

Don't know what is going on with updating panels to github. I've updated the TrimLFO panel twice and the same panel (original upload) is still in the repo. Updated the One Band panel also the exact same way and the larger sized dev version updated fine.

Anyway... I will delete the Trim panel and upload a new panel to master. Will that change take effect or will it require a new version in order for clients to update?

There is a gradient on the panel which just requires deletion not sure if its significant enough for github to detect the change in the file.

@Coirt
Copy link
Author

Coirt commented Feb 20, 2019

@cschol
Did I do something wrong the makefile everything seems correct in the make my end.

@Coirt
Copy link
Author

Coirt commented Mar 5, 2019

@cschol cschol reopened this Mar 5, 2019
@cschol
Copy link
Collaborator

cschol commented Mar 6, 2019

Do you want me to hook the build up to the 0.6.5 branch? Otherwise, you have to either create a tag for 0.6.5 or merge the 0.6.5 branch into master.

@Coirt
Copy link
Author

Coirt commented Dec 2, 2021

Suppose I'd better submit the new version.

Master at version v2.3.0
Commit: 64376ea01035343245498bc3934d25395af79d3b

@cschol cschol reopened this Dec 2, 2021
@cschol
Copy link
Collaborator

cschol commented Dec 2, 2021

Failed to load SVG file: Coirt/Bark#35

@Coirt
Copy link
Author

Coirt commented Dec 2, 2021

commit: 270891d7b257405e22ddf1ee1e9e96f56aa413ca fixes the issue

@cschol cschol reopened this Dec 3, 2021
@cschol cschol closed this as completed Dec 3, 2021
@Coirt
Copy link
Author

Coirt commented Jan 2, 2022

commit 8a1469f2096876c9c01a65319fe28535b140ff24
master v2.3.1

@cschol cschol reopened this Jan 2, 2022
@cschol
Copy link
Collaborator

cschol commented Jan 2, 2022

Version was not updated to 2.3.1 in manifest.

@Coirt
Copy link
Author

Coirt commented Jan 4, 2022

Interesting received some error when I did so but looked to be updated. Should be fixed now.

commit: ee3db2842c714ad8e21c51bda4b768f46df98020

@cschol
Copy link
Collaborator

cschol commented Sep 9, 2023

Plugin fails to compile on macOS arm64 platform: Coirt/Bark#39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Integration
Development

No branches or pull requests

3 participants