Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mojo #687

Open
tomdasilva opened this issue Jul 21, 2021 · 17 comments
Open

Mojo #687

tomdasilva opened this issue Jul 21, 2021 · 17 comments
Labels

Comments

@tomdasilva
Copy link

https://github.com/tomdasilva/Mojo

Hi !
I hope those three modules will be ok for getting into the VCV Library :)
Best Regards
Tom

@cschol cschol added the plugin label Jul 26, 2021
@cschol
Copy link
Collaborator

cschol commented Aug 4, 2021

Build artifacts committed to the repository: tomdasilva/Mojo#1
Invalid characters in plugin.json: tomdasilva/Mojo#2

@tomdasilva
Copy link
Author

Hi ! invalid characters have been modified in the plugin.json file :)

@cschol
Copy link
Collaborator

cschol commented Aug 11, 2021

Thanks. Build artifacts are still an issue though.

@tomdasilva
Copy link
Author

Hi ! I hope everything is fine now ...
thanks !

@cschol
Copy link
Collaborator

cschol commented Aug 17, 2021

@tomdasilva dist directory and plugin.dll need to be removed also with the same methodology. All of these artifacts will be rebuilt during the build process. Thanks.

@tomdasilva
Copy link
Author

Ok ! Is it fine now ? Thanks a lot :)

@cschol
Copy link
Collaborator

cschol commented Aug 17, 2021

One more thing: sourceURL in the plugin.json still contains weird characters. Everything else looks good.

@tomdasilva
Copy link
Author

So many issues ;) i corrected it !

@cschol
Copy link
Collaborator

cschol commented Aug 17, 2021

Your plugin has been integrated and will be available for all supported platforms with the next Plugin Manager update. Please let us know in this issue when a new version is available. We will reopen it. Thank you for providing your plugin to the Rack community.

@tomdasilva
Copy link
Author

So great ! thanks lot !

@tomdasilva
Copy link
Author

Hi ! I updated my plugin.json file for the migration from v1 to v2 :)
Thnaks to have a look at it, i hope everything will be ok !

Have a good day

https://github.com/tomdasilva/Mojo

@cschol
Copy link
Collaborator

cschol commented Nov 5, 2021

Great job! Your plugin passed all integration tests and builds successfully against the current SDK git.219bbaf1 for all supported platforms using the new v2 toolchain.

However, we are not accepting submissions to the library for v2 of Rack yet.
We will let developers know when to submit their v2 plugins to the library. Thank you.

@cschol cschol reopened this Dec 5, 2021
@cschol cschol mentioned this issue Dec 5, 2021
@cschol
Copy link
Collaborator

cschol commented Dec 5, 2021

Update requested for v2.

@tomdasilva
Copy link
Author

tomdasilva commented Jun 2, 2024

Hi ! I made some major updates to my Plugin with three new modules. I wish to push them to the VCV library :)
Thanks to have a look at it ! Have good day

New version: v3.0 (https://github.com/tomdasilva/Mojo - updates were pushed to main branch)

@cschol
Copy link
Collaborator

cschol commented Jun 23, 2024

Manifest issues: tomdasilva/Mojo#5

@AndrewBelt
Copy link
Member

Looks like @tomdasilva fixed this.

@cschol
Copy link
Collaborator

cschol commented Jul 22, 2024

Latest plugin revision crashes Rack when module browser loads. This is on GNU/Linux. @tomdasilva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Integration
Development

No branches or pull requests

3 participants