Ghidra 11.2 issues

[tmr232]

Ghidra 11.2 moved some things around:

• The site-packages directory was moved
• Python was renamed to Jython in all important places

This means that we need to adjust both our setup (installing vendored packages) and our code (importing the PythonScript class).

To simplify future updates, vendored package installation now uses a Python script to find the sitepackages and copy the packages over.

[tmr232]

@fmagin @clearbluejar can you take a look at the resulting artifacts and see that they make sense?
I've not used Ghidra in ages, and I don't wanna release something broken...

[fmagin]

I think the crucial change here is that they merged https://github.com/dod-cyber-crime-center/pyhidra into the core ghidra release, so it might be possible to migrate this entire project to Python 3?

[tmr232]

@fmagin Oh, that's cool. Do you wanna work on that? I find it unlikely that I'll get to that anytime soon...

[fmagin]

Can't guarantee anything, but I'll see if I can justify spending some time on it

[fmagin]

Apparently the Python 3 support is planned for 11.3, but the preparation for it might have broken some minor things already?

[tmr232]

@fmagin that seems to be the case.
If the stubs generated by this PR are ok (can you check?) I think we can merge this now.
Then, when there's a version that allows running Python3 directly from the headless analyzer, we can port the code and simplify it significantly.

[fmagin]

I thought Ghidra 11.2 needs JDK 21 now? I'm surprised this still works

[tmr232]

Updated. Let's see how this works now.

[fmagin]

Same as above

[fmagin]

If the stubs generated by this PR are ok (can you check?)

I have barely ever used Ghidra with Python, so I'm not sure how much I can check there, actually. I'd guess they are fine?

[tmr232]

I think we'll just assume they are fine, and fix anything that comes up if anyone reports a bug...

We'll probably need to do more testing once we get the Python3 stuff in.

Also - kinda funny that neither of us actually uses this...

So, I think I'll go ahead and merge this?

[fmagin]

Also - kinda funny that neither of us actually uses this...

I know people actually using it for work, but I think they aren't on Ghidra 11.2 yet. But I'd expect an increase in popularity once Ghidra supports Python3 out of the box. Would be interesting if a modern IDE actually detects the existence of a -stub package on PyPI and automatically suggests installing it?

So, I think I'll go ahead and merge this?

Sounds good

[clearbluejar]

many of use still use it! thanks for the fix