Simplified pip and conda environment; pypi deployment #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthew-w-lundy @deividribeiro - could you have a look why the vegas workflow is failing? I am not sure I understand the different step of docker generation and pip installation. Maybe it is a small thing only - having this PR included would really by nice! |
|
Appears to be how in the docker image we are pip installing. Locally running the instructions work in a clean conda environment. I will see if I can modify the test to reasonably still pass with changes to the install. |
|
@matthew-w-lundy - any progress on this issue? Being able to merge this PR would really be nice, as it simplifies installation. |
|
Taking a look at this again today to try and resolve |
matthew-w-lundy
force-pushed
the
pypi-eventdisplay
branch
from
29f0691
to
578ec0d
Compare
forcing an update to setuptools before pip install
and force a redo of the runtime tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests simplifies installation and usage of V2DL3 significantly.
A simple
pip install v2dl3should do all and then we call the three scripts as command line tools:v2dl3-vegasv2dl3-generate-index-filev2dl3-eventdisplayIt is very nice that we can use the same installation for eventdisplay and vegas flavours (at this point only for pip; could do this like also in future for the conda environments).
Replaces also setup.py by the more modern pyproject.toml approach.
Other changes: