Coerce int range filter values for accuracy and rename some methods for clarity #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main goal here is to make sure passed integer range filter values don't produce results (i.e. not filter) values outside the range, even if the values passed are floating point. Important to note that range filters are inclusive! Thus, for example, a passed range filter of [4.5, 6.5] should result in integer conversions of [5, 6] so we don't include 4s or 7s. To do this, we use floor on max values and ceil on min values. Unlike truncation (which we were doing before via longValue()), which does mirror-image conversion for negative numbers, floor and ceil are consistent so we don't need special logic for negative values.