Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow wgcna collections in correlation metadata app #819

Merged
merged 6 commits into from
Feb 12, 2024
Merged

Conversation

asizemore
Copy link
Member

@asizemore asizemore commented Feb 2, 2024

This PR includes changes that let folks see the wgcna data working in the correlations apps.

To run, use jbrestel plasmo backend.

02/02/24 - can select the collections for the correlation app. Found issue on the backend VEuPathDB/microbiomeComputations#81

02/09/24 - all resolved. Data looks good and works!

To Do before asking for review

  • Change the hard-coded assay entity ids to a function that just finds the entities with collections.

For testing, please check that there are two collections options in the Correlation (assay x metadata) app.

I've left the Functional Associations correlations app out for now. There are open questions about how to handle that app.

@d-callan
Copy link
Member

d-callan commented Feb 5, 2024

backend work relating to this is now merged

@asizemore asizemore marked this pull request as ready for review February 9, 2024 16:26
@dmfalke
Copy link
Member

dmfalke commented Feb 9, 2024

The code changes look good. I'm about to test.

In the mean time, I'll ask: Is there a plan for finding assay entities in a different way? When should we expect the approach in the PR to no longer work?

Copy link
Member

@dmfalke dmfalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Looks good!

@asizemore
Copy link
Member Author

Good question. Implementing an isAssay annotation like discussed here is still the plan long term. The approach of finding the entities with collections will work as long as collections live on entities that are all leaves of the same branch of the tree.

@asizemore asizemore merged commit 5ed8281 into main Feb 12, 2024
1 check passed
@asizemore asizemore deleted the wgcna-eda branch February 12, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants