CATFLOW Geospatial Tool #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaelicke
requested changes
Jun 5, 2023
There was a problem hiding this comment.
Nice work @Ash-Manoj ! Sorry for my late response, I forgot about this pull request. There are some minor changes requested.
| type: float | ||
| description: Optional multiplier for when the vertical and horizontal units are not the same | ||
| default: None |
There was a problem hiding this comment.
This parameter does not have a default, but is optional, as the tool will set it to 100. The difference between optional and default is a bit confusing. You can add optional: true here and add to the description that the threshold is always 100, but you can overwrite this constant
|
Any progress on this? |
|
|
Working on the changes. Should be able to push by next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructured the run.py for generating required Raster files for CATFLOW Hillslope Wizard using a single Tool.