Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change "reference"/"identifier" to "id" #114

Merged
merged 8 commits into from
Dec 11, 2019
Merged

change "reference"/"identifier" to "id" #114

merged 8 commits into from
Dec 11, 2019

Conversation

orarogovin
Copy link
Collaborator

No description provided.

@stevevanhooser
Copy link
Contributor

This is looking good. I want to request a couple of additional changes before we merge.

I'll describe in next message

@stevevanhooser
Copy link
Contributor

OK. We need to better document the documents that each document "depends on". I did this for spikewaves.json on the branch id_changes.

Can you edit for the other documents as well?

Thanks!
Steve

{
"document_class": {
"definition": "$NDIDOCUMENTPATH/apps/spikeextractor/spikewaves.json",
"validation": "$NDISCHEMAPATH/apps/spikeextractor/spikewaves_schema.json",
"class_name": "spikeextractor-spikewaves",
"class_version": 1,
"superclasses": [
{ "definition": "$NDIDOCUMENTPATH/ndi_document.json" },
{ "definition": "$NDIDOCUMENTPATH/ndi_document_probe.json" },
{ "definition": "$NDIDOCUMENTPATH/ndi_document_epochid.json" },
{ "definition": "$NDIDOCUMENTPATH/ndi_document_app.json" }
]
},
"depends_on": [
{"extraction_parameters_id": "" }
]
"spikewaves": {
"extraction_name": "",
}
}

@orarogovin
Copy link
Collaborator Author

Made changes to the depends_on documentation. Let me know if there's anything else I should fix.

@stevevanhooser stevevanhooser merged commit ccbf6e8 into master Dec 11, 2019
@stevevanhooser stevevanhooser deleted the id_changes branch December 11, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants