Add loading of packaged libraries by feature flag #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #45:
I've implemented this function. I'm only up to chapter 5 in the Rust book, so improvements are welcome!
I've not added any tests. Am I right in thinking there's none for the other configuration loading functions either? I'm also couldn't work out how you add tests for whether a feature flag is enabled or not anyway.
I was a bit less successful here. From reading up on this the supported way of doing this with Cargo seems to be through feature flags. I implemented that for the
vhdl_parser
project with thepackaged
feature, which is also added to thevhdl_ls
project to pass it through.While this seems to be working for building it locally to the project
It looks like feature flags aren't supported when building at the workspace level at the moment. The CI build could build from within each folder separately, but that's not what it does now.