Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing std_logic_misc pkg to IEEE lib #68

Merged
merged 20 commits into from
Apr 2, 2023
Merged

Conversation

c-thaler
Copy link
Contributor

This adds the std_logic_mis package to the IEEE libraries. AFAI this is a non-standard package available only in the Synopsys implementation.

@Paebbels
Copy link
Member

Please incorporate these changes - I tried to propose them as direct changes in GitHub, but it doesn't allow suggestions outside of your edited regions ...

Please split the list into normal (VHDL-2008) packages and additional Synopsys packages:

PACKAGES = (
	(Math_Real, Math_Real_Body),
	(Math_Complex, Math_Complex_Body),
	(Std_logic_1164, Std_logic_1164_Body),
	(std_logic_textio, None),
	(Numeric_Bit, Numeric_Bit_Body),
	(Numeric_Bit_Unsigned, Numeric_Bit_Unsigned_Body),
	(Numeric_Std, Numeric_Std_Body),
	(Numeric_Std_Unsigned, Numeric_Std_Unsigned_Body),
	(Fixed_Float_Types, None),
	(Fixed_Generic_Pkg, Fixed_Generic_Pkg_Body),
	(Fixed_Pkg, None),
	(Float_Generic_Pkg, Float_Generic_Pkg_Body),
	(Float_Pkg, None),
)
SYNOPSYS = (
	(Std_logic_misc, Std_logic_misc_Body),
)

At next it would be best to add a method before AddLibrary like LoadSynopsysPackages. This method would add more packages listed in SYNOPSYS to the ieee library. See these related methods: https://github.com/VHDL/pyVHDLModel/blob/main/pyVHDLModel/__init__.py?ts=2#L447-L471

Is could then be used like this:

design = Design()

# ...

design.LoadStdLibrary()
ieee = design.LoadIEEELibrary()
ieee.LoadSynopsysPackages()

Synopsys packages must be loaded explicitly now. Also fixed requirements
since pyTooling 4.0 is not compatible.
@c-thaler
Copy link
Contributor Author

c-thaler commented Apr 1, 2023

I added a LoadSynopsysPackages() to the Ieee library class.

@Paebbels Paebbels changed the base branch from main to dev April 2, 2023 16:07
@Paebbels Paebbels merged commit 93bf4b7 into VHDL:dev Apr 2, 2023
@Paebbels Paebbels mentioned this pull request Apr 2, 2023
@Paebbels
Copy link
Member

Paebbels commented Apr 2, 2023

Thanks for your contribution. I redirected the merge to dev and followed the release process by merging dev to main in #69 and finally tagging it as v0.24.1. Release should be published to PyPI in 3-4 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants