Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package namespace bugs #82

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Fix package namespace bugs #82

merged 3 commits into from
Jul 29, 2024

Commits on Jul 29, 2024

  1. Fixing bug where namespace elements were added with non-normalized id… 

    …entifier. This caused issues where elements would not be found if identifier and normalizedIdentifier did not match.
    Thomas Cenova committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    b81220e View commit details
    Browse the repository at this point in the history

  2. Fixing issue where if a declaredItem has multiple identifiers (like c… 

    …onstants), then this code would fail. Adding a check to see if the _normalizedIdentifiers attr exists, and if so add a entry for each identifier
    Thomas Cenova committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    3889113 View commit details
    Browse the repository at this point in the history

  3. Swap to using isinstance of mixins per review. 

    Co-authored-by: Patrick Lehmann <Paebbels@gmail.com>
    @Tcenova @Paebbels
    Tcenova and Paebbels authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    5cbcc96 View commit details
    Browse the repository at this point in the history