Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if executing a set-uid or set-gid binary #296

Merged
merged 5 commits into from
May 11, 2018
Merged

Warn if executing a set-uid or set-gid binary #296

merged 5 commits into from
May 11, 2018

Conversation

remram44
Copy link
Member

Fixes #295

@remram44 remram44 added T-enhancement Type: En enhancement to existing code, or a new feature C-tracer (C) Component: The C part of the tracer codebase (_pytracer extension) A-pending-review Attention: This is ready for review and can be merged afterwards labels May 10, 2018
@remram44 remram44 added this to the 1.0.13 milestone May 10, 2018
@remram44 remram44 force-pushed the suid-warning branch 2 times, most recently from db12ac8 to 7b26267 Compare May 10, 2018 21:40
@remram44
Copy link
Member Author

Example:

$ reprozip testrun /usr/bin/crontab   
[REPROZIP] 19:42:22.368 WARNING: [16186] executing set-uid binary! For security,
Linux will not give the process any privileges from set-uid while it is being
traced. This will probably break whatever you are tracing.
/var/spool/cron/: mkstemp: Permission denied
...
Warning: program exited with non-zero code 1

Log as info instead of warning, but still log.
This doesn't align because the logs are prefixed by timestamp and
severity anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pending-review Attention: This is ready for review and can be merged afterwards C-tracer (C) Component: The C part of the tracer codebase (_pytracer extension) T-enhancement Type: En enhancement to existing code, or a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant