Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement][a11y] Доступность карточек #4186

Closed
eugpoloz opened this issue Feb 9, 2023 · 1 comment · Fixed by #7238
Closed

[Enhancement][a11y] Доступность карточек #4186

eugpoloz opened this issue Feb 9, 2023 · 1 comment · Fixed by #7238
Assignees
@EldarMuhamethanov
Labels
a11y Доступность (цифровая) cmp:card cmp:card-grid cmp:card-scroll cmp:content-card type:enhancement
Milestone
v6.6.0

Comments

@eugpoloz
Copy link
Contributor

eugpoloz commented Feb 9, 2023

Есть отличная статья про то, как сделать карточки доступными (да, она 2018 года); хорошо бы взять ее за основу и прокачать доступность наших карточек.

Предложения

  • CardGrid, CardScroll: сделать рутовым элементом <ul> вместо <div>
    • возможно — дать возможность пробросить Component
  • Card, ContentCard: сделать рутовым элементом <li> вместо <div>
    • возможно — дать возможность пробросить Component
  • попробовать отвязать ContentCard от Tappable (связано с [Bug] Tappable очень сложный для рендера #1443). Сложность Tappable в принципе с точки зрения доступности очень сильно мешает
@eugpoloz eugpoloz added this to VKUI Feb 9, 2023
@github-project-automation github-project-automation bot moved this to 🗃 Backlog in VKUI Feb 9, 2023
@eugpoloz eugpoloz moved this from 🗃 Backlog to 🔜 To do in VKUI Feb 9, 2023
@eugpoloz eugpoloz mentioned this issue Feb 9, 2023
Merged
@eugpoloz eugpoloz mentioned this issue Sep 20, 2023
Closed
@inomdzhon inomdzhon added this to the v6 milestone Nov 3, 2023
@inomdzhon inomdzhon removed this from the v6 milestone Nov 13, 2023
@EldarMuhamethanov EldarMuhamethanov self-assigned this Jul 23, 2024
@EldarMuhamethanov EldarMuhamethanov moved this from 🔜 To do to 🔧 In progress in VKUI Jul 23, 2024
@EldarMuhamethanov EldarMuhamethanov mentioned this issue Jul 23, 2024
Merged
2 tasks
@EldarMuhamethanov EldarMuhamethanov moved this from 🔧 In progress to 👀 In Review in VKUI Jul 24, 2024
@mendrew mendrew added this to the v6.6.0 milestone Aug 22, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Aug 22, 2024
@vkcom-publisher
Copy link
Contributor

✅ v6.6.0 🎉

@andrey-medvedev-vk andrey-medvedev-vk mentioned this issue Jan 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EldarMuhamethanov EldarMuhamethanov

Labels
a11y Доступность (цифровая) cmp:card cmp:card-grid cmp:card-scroll cmp:content-card type:enhancement
Projects
VKUI
Archived in project
Milestone
v6.6.0
Development

Successfully merging a pull request may close this issue.

feat: add prop Component to Card, CardGrid, CardScroll, ContentCard VKCOM/VKUI
5 participants
@mendrew @inomdzhon @eugpoloz @EldarMuhamethanov @vkcom-publisher