Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add prop Component to Card, CardGrid, CardScroll, ContentCard #7238

Merged
merged 16 commits into from
Aug 22, 2024
Merged

feat: add prop Component to Card, CardGrid, CardScroll, ContentCard #7238

merged 16 commits into from
Aug 22, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

  • e2e-тесты
  • Документация фичи

Описание

Необходимо улучшить цифровую доступность компонентов Card, CardGrid, CardScroll, ContentCard использованием семантических тегов

Изменения

  • Добавил пропс Component для компонентов Card, CardGrid, CardScroll, ContentCard
  • По умолчанию Component сделал тегом "li" для Card и ContentCard
  • По умолчанию Component сделал тегом "ul" для CardGrid и CardScroll
  • Добавил раздел с Цифровой доступностью для CardGrid

Дополнительно

  • Добавил скриншотные тесты для компонента CardGrid

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner July 23, 2024 12:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 23, 2024 •
edited
Loading

size-limit report 📦

Path Size
JS 378.22 KB (+0.05% 🔺)
JS (gzip) 114.69 KB (+0.05% 🔺)
JS (brotli) 94.17 KB (-0.03% 🔽)
JS import Div (tree shaking) 1.39 KB (0%)
CSS 305.8 KB (+0.05% 🔺)
CSS (gzip) 39.25 KB (+0.07% 🔺)
CSS (brotli) 31.47 KB (-0.05% 🔽)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jul 23, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 23, 2024 •
edited
Loading

👀 Docs deployed

Commit a130209

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 23, 2024 •
edited
Loading

e2e tests

Playwright Report

@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (a7b79b3) to head (a130209).
Report is 75 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7238      +/-   ##
==========================================
+ Coverage   83.63%   92.69%   +9.06%     
==========================================
  Files         369      369              
  Lines       11132    11038      -94     
  Branches     3638     3620      -18     
==========================================
+ Hits         9310    10232     +922     
+ Misses       1822      806    -1016
Flag Coverage Δ
unittests 92.69% <100.00%> (+9.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Aug 2, 2024
@EldarMuhamethanov EldarMuhamethanov mentioned this pull request Aug 7, 2024
Closed
mendrew
mendrew reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏

Только nit по TODO.

packages/vkui/src/components/Card/Card.tsx Outdated Show resolved Hide resolved
mendrew
mendrew previously approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

mendrew
mendrew previously approved these changes Aug 7, 2024
View reviewed changes
@EldarMuhamethanov @inomdzhon
fix: fix TODO
26dfca0 
Co-authored-by: Inomdzhon Mirdzhamolov <i.mirdzhamolov@vk.team>
@EldarMuhamethanov @inomdzhon
fix: fix TODO
3d34a3a 
Co-authored-by: Inomdzhon Mirdzhamolov <i.mirdzhamolov@vk.team>
EldarMuhamethanov and others added 2 commits August 12, 2024 12:56
@EldarMuhamethanov @inomdzhon
fix: fix TODO
182ca6f 
Co-authored-by: Inomdzhon Mirdzhamolov <i.mirdzhamolov@vk.team>
@EldarMuhamethanov @inomdzhon
fix: fix TODO
a130209 
Co-authored-by: Inomdzhon Mirdzhamolov <i.mirdzhamolov@vk.team>
@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Aug 19, 2024
@vkcom-publisher vkcom-publisher removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Aug 20, 2024
@mendrew mendrew merged commit ec558fb into master Aug 22, 2024
27 checks passed
@mendrew mendrew deleted the e.muhamethanov/4186/improve-cards-a11y branch August 22, 2024 07:07
@EldarMuhamethanov EldarMuhamethanov mentioned this pull request Aug 26, 2024
Open
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevereCloud SevereCloud SevereCloud left review comments

@mendrew mendrew mendrew approved these changes

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement][a11y] Доступность карточек
5 participants
@EldarMuhamethanov @mendrew @inomdzhon @SevereCloud @vkcom-publisher