Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][ToolButton] Тюнинг фонов ToolButton #8198

Closed
2 tasks done
qurle opened this issue Jan 27, 2025 · 2 comments · Fixed by #8201
Closed
2 tasks done

[Bug][ToolButton] Тюнинг фонов ToolButton #8198

qurle opened this issue Jan 27, 2025 · 2 comments · Fixed by #8201
Assignees
@inomdzhon
Labels
cmp:tool-button ToolButton type:bug
Milestone
v7.1.2

Comments

@qurle
Copy link
Contributor

qurle commented Jan 27, 2025 •
edited by inomdzhon
Loading

Описание

  • После обновления цвета primary-кнопок у ToolButton сильно сломалась обратная совместимость.
    В кнопку mode="secondary" возвращаем непрозрачный цвет --vkui--color_background_secondary. Жертвуем полупрозрачным цветом --vkui--color_background_secondary_alpha и однозначной связью цветов с Button.
  • В кнопке appearance="neutral" mode="primary" меняем специфичный и неподходящий по смыслу цвет --vkui--color_background_modal_inverse на --vkui--color_background_content_inverse

Скриншоты

image
@qurle qurle added this to VKUI Jan 27, 2025
@github-project-automation github-project-automation bot moved this to 🗃 Backlog in VKUI Jan 27, 2025
@qurle
Copy link
Contributor Author

qurle commented Jan 27, 2025

Страшно ли мне?

@inomdzhon inomdzhon changed the title [Feature][ToolButton] Тюнинг фонов ToolButton [Bug][ToolButton] Тюнинг фонов ToolButton Jan 27, 2025
@inomdzhon inomdzhon moved this from 🗃 Backlog to 🔜 To do in VKUI Jan 27, 2025
@inomdzhon inomdzhon added this to the v7.1.2 milestone Jan 27, 2025
@inomdzhon inomdzhon self-assigned this Jan 27, 2025
@inomdzhon inomdzhon moved this from 🔜 To do to ⛔️ Blocked in VKUI Jan 27, 2025
@inomdzhon inomdzhon moved this from ⛔️ Blocked to 🔧 In progress in VKUI Jan 27, 2025
@inomdzhon inomdzhon mentioned this issue Jan 28, 2025
Merged
3 tasks
@inomdzhon inomdzhon moved this from 🔧 In progress to 👀 In Review in VKUI Jan 28, 2025
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Jan 28, 2025
@vkcom-publisher
Copy link
Contributor

✅ v7.1.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inomdzhon inomdzhon

Labels
cmp:tool-button ToolButton type:bug
Projects
VKUI
Archived in project
Milestone
v7.1.2
Development

Successfully merging a pull request may close this issue.

fix(ToolButton): rm alpha from bg for mode="secondary" VKCOM/VKUI
3 participants
@inomdzhon @qurle @vkcom-publisher