fix(ToolButton): rm alpha from bg for mode="secondary"
#8201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inomdzhon
added
the
patch
SevereCloud
approved these changes
Jan 28, 2025
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
e2e tests |
👀 Docs deployed
Commit fae4120 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8201 +/- ##
=======================================
Coverage 95.49% 95.49%
=======================================
Files 403 403
Lines 11503 11503
Branches 3812 3812
=======================================
Hits 10985 10985
Misses 518 518
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrey-medvedev-vk
approved these changes
Jan 28, 2025
qurle
approved these changes
Jan 28, 2025
vkcom-publisher
pushed a commit
that referenced
this pull request
Jan 28, 2025
h2. Release notes h2. Исправления - ToolButton: - при `mode="secondary"` у фона теперь нет прозрачности; - для `mode="primary" appearance="neutral"` заменён токен с `--vkui--color_background_modal_inverse` на `--vkui--color_background_content_inverse`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Unit-тесты[ ] Документация фичиОписание
см. #8198
Release notes
Исправления
mode="secondary"у фона теперь нет прозрачности;mode="primary" appearance="neutral"заменён токен с--vkui--color_background_modal_inverseна--vkui--color_background_content_inverse.