Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NativeSelect): apply selectType to FormField #5539

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

BlackySoul
Copy link
Contributor

Даём возможность прокинуть selectType на FormField

@BlackySoul BlackySoul added this to the v5.7.0 milestone Jul 28, 2023
@BlackySoul BlackySoul requested a review from a team as a code owner July 28, 2023 13:11
@BlackySoul BlackySoul self-assigned this Jul 28, 2023
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 310b94f:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

👀 Docs deployed

Commit 310b94f

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 311.64 KB (+0.01% 🔺)
JS (gzip) 91.17 KB (+0.01% 🔺)
JS (brotli) 75.65 KB (-0.08% 🔽)
JS import Div (tree shaking) 2.97 KB (0%)
CSS 271.44 KB (0%)
CSS (gzip) 35.56 KB (0%)
CSS (brotli) 28.21 KB (0%)

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1091c34) 81.70% compared to head (310b94f) 81.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5539   +/-   ##
=======================================
  Coverage   81.70%   81.70%           
=======================================
  Files         286      286           
  Lines        9581     9582    +1     
  Branches     3056     3056           
=======================================
+ Hits         7828     7829    +1     
  Misses       1753     1753           
Flag Coverage Δ
unittests 81.70% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../vkui/src/components/NativeSelect/NativeSelect.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

e2e tests

Playwright Report

@BlackySoul BlackySoul merged commit ab61163 into master Jul 31, 2023
14 checks passed
@BlackySoul BlackySoul deleted the blackysoul/fix_nativeselect_mode branch July 31, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants