Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Input): disable controls for type="number" #5607

Merged

Conversation

inomdzhon
Copy link
Contributor

Отключаем нативные элементы для <input type="number" /> при передаче type="number" в Input.

Иначе приходится использовать кастомный <input type="number" /> внутри FormField и сбрасывать ему стили.

@inomdzhon inomdzhon added this to the v5.8.0 milestone Aug 11, 2023
@inomdzhon inomdzhon self-assigned this Aug 11, 2023
@inomdzhon inomdzhon requested a review from a team as a code owner August 11, 2023 12:30
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fd99930:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

👀 Docs deployed

Commit fd99930

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fdf9a83) 81.82% compared to head (fd99930) 81.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5607   +/-   ##
=======================================
  Coverage   81.82%   81.82%           
=======================================
  Files         289      289           
  Lines        9652     9652           
  Branches     3071     3071           
=======================================
  Hits         7898     7898           
  Misses       1754     1754           
Flag Coverage Δ
unittests 81.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 313.5 KB (0%)
JS (gzip) 91.72 KB (0%)
JS (brotli) 76.08 KB (0%)
JS import Div (tree shaking) 2.97 KB (0%)
CSS 273.99 KB (+0.06% 🔺)
CSS (gzip) 35.74 KB (+0.1% 🔺)
CSS (brotli) 28.33 KB (+0.1% 🔺)

@github-actions
Copy link
Contributor

e2e tests

Playwright Report

@inomdzhon inomdzhon merged commit 4753a6c into master Aug 11, 2023
14 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/feat/disable-input-type-number-style branch August 11, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants