fix(ConfigProvider) Allow duplicated classes in the body created by ConfigProvider #5633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f47870a:
|
To make sure embedded apps do not remove body class name of the main app which is required for tokens. Each app will add it's own class and remove it whenever they need.
mendrew
force-pushed
the
mendrew/fix/5518/ConfigProvider/allow-to-duplicate-classname-in-body-class-attribute
branch
from
e09338c
to
8c27b61
Compare
size-limit report 📦
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5633 +/- ##
==========================================
+ Coverage 81.76% 81.78% +0.01%
==========================================
Files 290 290
Lines 9731 9746 +15
Branches 3108 3113 +5
==========================================
+ Hits 7957 7971 +14
- Misses 1774 1775 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
👀 Docs deployedCommit f47870a |
e2e tests |
inomdzhon
reviewed
Aug 17, 2023
packages/vkui/src/components/ConfigProvider/ConfigProvider.test.tsx
Outdated
Show resolved
Hide resolved
inomdzhon
previously approved these changes
Aug 17, 2023
SevereCloud
previously approved these changes
Aug 17, 2023
SevereCloud
previously approved these changes
Aug 17, 2023
SevereCloud
approved these changes
Aug 17, 2023
inomdzhon
approved these changes
Aug 17, 2023
mendrew
deleted the
mendrew/fix/5518/ConfigProvider/allow-to-duplicate-classname-in-body-class-attribute
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #5518
Для того чтобы независимые приложения не удаляли класс главного приложений из body при размонтировании мы позволяем каждому приложению на странице добавить свой класс в body с помощью
ConfigProvider, даже если такой класс уже есть.Работа с классами
bodyведётся с помощьclassNameа неclassList(который не допускает дубликатов).