Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bad env NODE_ENVIRONMENT #5766

Merged
merged 1 commit into from
Sep 10, 2023
Merged

fix: bad env NODE_ENVIRONMENT #5766

merged 1 commit into from
Sep 10, 2023

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Sep 9, 2023 •
edited by inomdzhon
Loading

Сломалась сборка в vite из-за переменной.
Переименовываем NODE_ENVIRONMENT в NODE_ENV и фиксируем в типах

@SevereCloud
fix: bad env NODE_ENVIRONMENT
620f746 
Сломалась сборка в vite из-за переменной.
Переименовываем `NODE_ENVIRONMENT` в `NODE_ENV` и фиксируем в типах
@SevereCloud SevereCloud requested a review from a team as a code owner September 9, 2023 16:30
@SevereCloud SevereCloud self-assigned this Sep 9, 2023
@SevereCloud SevereCloud added patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v5 Автоматизация: PR продублируется в ветку v5 labels Sep 9, 2023
@SevereCloud SevereCloud added this to the v5.8.1 milestone Sep 9, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 9, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 620f746:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

size-limit report 📦

Path Size
JS 346.1 KB (-0.43% 🔽)
JS (gzip) 103.22 KB (-0.8% 🔽)
JS (brotli) 84.33 KB (-0.54% 🔽)
JS import Div (tree shaking) 3.04 KB (0%)
CSS 278.03 KB (0%)
CSS (gzip) 36.25 KB (0%)
CSS (brotli) 28.68 KB (0%)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

e2e tests

Playwright Report

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (752c0d6) 81.99% compared to head (620f746) 81.99%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5766   +/-   ##
=======================================
  Coverage   81.99%   81.99%           
=======================================
  Files         298      298           
  Lines        9839     9839           
  Branches     3115     3115           
=======================================
  Hits         8067     8067           
  Misses       1772     1772
Flag Coverage Δ
unittests 81.99% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...mponents/AdaptivityProvider/AdaptivityProvider.tsx 97.46% <100.00%> (ø)
packages/vkui/src/components/AppRoot/AppRoot.tsx 92.30% <100.00%> (ø)
...i/src/components/ConfigProvider/ConfigProvider.tsx 81.57% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

👀 Docs deployed

Commit 620f746

@BlackySoul BlackySoul mentioned this pull request Sep 10, 2023
Closed
@SevereCloud SevereCloud removed their assignment Sep 10, 2023
@SevereCloud SevereCloud removed this from the v5.8.1 milestone Sep 10, 2023
@SevereCloud SevereCloud merged commit 88a49ea into master Sep 10, 2023
25 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/bad-env-NODE_ENVIRONMENT branch September 10, 2023 17:15
vkcom-publisher pushed a commit that referenced this pull request Sep 10, 2023
@SevereCloud @actions-user
fix: bad env NODE_ENVIRONMENT (#5766)
344c0da 
Сломалась сборка в vite из-за переменной.
Переименовываем `NODE_ENVIRONMENT` в `NODE_ENV` и фиксируем в типах
vkcom-publisher pushed a commit that referenced this pull request Sep 10, 2023
@SevereCloud @actions-user
fix: bad env NODE_ENVIRONMENT (#5766)
5ac27d5 
Сломалась сборка в vite из-за переменной.
Переименовываем `NODE_ENVIRONMENT` в `NODE_ENV` и фиксируем в типах
@mahnunchik
Copy link

Когда релиз?

@SevereCloud
Copy link
Contributor Author

В понедельник выпустим патч

@inomdzhon inomdzhon modified the milestone: v5.8.1 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackySoul BlackySoul BlackySoul approved these changes

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees
No one assigned
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v5 Автоматизация: PR продублируется в ветку v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Сломали сборку в Vite
4 participants
@SevereCloud @mahnunchik @inomdzhon @BlackySoul