Bump jscodeshift to fix ast error with TS satisfies operator #6986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit f452bb8 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6986 +/- ##
=======================================
Coverage 83.41% 83.41%
=======================================
Files 352 352
Lines 10538 10538
Branches 3498 3498
=======================================
Hits 8790 8790
Misses 1748 1748
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mendrew
force-pushed
the
mendrew/bump-jscodeshift
branch
from
e5003a9
to
c7ba8aa
Compare
vkcom-publisher
added
the
pr-needs-work
BlackySoul
force-pushed
the
mendrew/bump-jscodeshift
branch
from
4a4d48d
to
f452bb8
Compare
BlackySoul
removed
the
pr-needs-work
mendrew
commented
Jun 13, 2024
There was a problem hiding this comment.
Класс, @BlackySoul, спасибо, что обновила README по поводу появления лишних круглих скобочек.
Если б мог, то поставил бы 👍
inomdzhon
approved these changes
Jun 13, 2024
SevereCloud
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Старая версия
jscodeshiftне могла переваритьTS-файлы с новым синтаксисом, поэтому смирились с некоторыми нежелательными моментами + ап версии позволит порешать security alertИзменения
Сделали ап версии
jscodeshift, обновили снепшоты + порешали старуюTODO(вместо удаления файла просто выбросили ненужные части кода)