Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a11y): improve a11y in Radio and RadioGroup components #7089

Merged
merged 7 commits into from
Jun 28, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Jun 27, 2024


  • Компоненты соответствуют требованиям a11y
  • Unit-тесты a11y
  • Раздел доступность в Readme.md для Radio и RadioGroup

Описание

Необходимо доработать a11y для компонентов Radio и RadioGroup

Изменения

  • Доработал цифровую доступность для компонентов Radio и RadioGroup
  • Добавил роли для компонентов
  • Добавил тесты для проверки доступности компонентоа RadioGroup
  • Добавил разделы Цифровой доступности в документации компонентов

- Доработал цифровую доступность для компонентов Radio и RadioGroup
- Добавил роли для компонентов
- Добавил тесты для проверки доступности компонентоа RadioGroup
- Добавил разделы Цифровой доступности в документации компонентов
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner June 27, 2024 07:41
Copy link
Contributor

github-actions bot commented Jun 27, 2024

size-limit report 📦

Path Size
JS 368.65 KB (+0.02% 🔺)
JS (gzip) 112.87 KB (+0.01% 🔺)
JS (brotli) 92.87 KB (+0.03% 🔺)
JS import Div (tree shaking) 1.42 KB (0%)
CSS 289.81 KB (0%)
CSS (gzip) 37.66 KB (0%)
CSS (brotli) 30.44 KB (0%)

Copy link

codesandbox-ci bot commented Jun 27, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Jun 27, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Jun 27, 2024

👀 Docs deployed

Commit 9ee3e2e

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.75%. Comparing base (606ec64) to head (9ee3e2e).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7089      +/-   ##
==========================================
+ Coverage   83.67%   83.75%   +0.07%     
==========================================
  Files         353      353              
  Lines       10565    10628      +63     
  Branches     3499     3533      +34     
==========================================
+ Hits         8840     8901      +61     
- Misses       1725     1727       +2     
Flag Coverage Δ
unittests 83.75% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👍

packages/vkui/src/components/Radio/Radio.tsx Outdated Show resolved Hide resolved
packages/vkui/src/components/Radio/Radio.tsx Outdated Show resolved Hide resolved
packages/vkui/src/components/Radio/Radio.tsx Outdated Show resolved Hide resolved
packages/vkui/src/components/Radio/Radio.tsx Outdated Show resolved Hide resolved
packages/vkui/src/components/Radio/Radio.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 ❤️

@inomdzhon inomdzhon merged commit 78f5067 into master Jun 28, 2024
26 checks passed
@inomdzhon inomdzhon deleted the e.muhamethanov/3051/a11y-radio branch June 28, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement][a11y] Доступность Radio и RadioGroup
3 participants