Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useCustomEnsuredControl/useFloatingWithInteractions): Initialize preservedControlledValueRef with value #7099

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix(useCustomEnsuredControl/useFloatingWithInteractions): Initialize preservedControlledValueRef with value #7099

merged 1 commit into from
Jul 5, 2024

Commits on Jun 28, 2024

  1. Initialize preservedControlledValueRef with value 

    We got an error from users about'shown' in
useFloatingWithInteractions hook

TypeError: Uncaught TypeError: Cannot read properties of undefined (reading 'shown')

I wasn't able to catch this locally, or in test env, but
to make sure preservedControlledValueRef can't be undefined
if value is defind we give it a value.
    @mendrew
    mendrew committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    406784a View commit details
    Browse the repository at this point in the history