feat: add SelectionControl #7119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7119 +/- ##
==========================================
+ Coverage 83.59% 83.63% +0.03%
==========================================
Files 369 374 +5
Lines 11138 11171 +33
Branches 3640 3642 +2
==========================================
+ Hits 9311 9343 +32
- Misses 1827 1828 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e2e tests |
👀 Docs deployed
Commit 1f9a3a2 |
SevereCloud
force-pushed
the
SevereCloud/feat/add-SelectionControl
branch
from
1228f60 to
2b7de69
Compare
SevereCloud
force-pushed
the
SevereCloud/feat/add-SelectionControl
branch
from
0f11fe4 to
bf7c98c
Compare
SevereCloud
force-pushed
the
SevereCloud/feat/add-SelectionControl
branch
from
bf7c98c to
5e7f276
Compare
vkcom-publisher
added
the
pr-needs-work
mendrew
previously approved these changes
Jul 17, 2024
vkcom-publisher
removed
the
pr-needs-work
vkcom-publisher
added
pr-needs-work
inomdzhon
reviewed
Jul 30, 2024
packages/vkui/src/components/SelectionControl/SelectionControlLabel/SelectionControlLabel.tsx
Outdated
Show resolved
Hide resolved
packages/vkui/src/components/SelectionControl/SelectionControl.tsx
Outdated
Show resolved
Hide resolved
.../vkui/src/components/SelectionControl/SelectionControlLabel/SelectionControlLabel.module.css
Outdated
Show resolved
Hide resolved
packages/vkui/src/components/Checkbox/CheckboxSimple/CheckboxSimple.tsx
Outdated
Show resolved
Hide resolved
vkcom-publisher
added
the
pr-needs-work
SevereCloud
force-pushed
the
SevereCloud/feat/add-SelectionControl
branch
from
5e7f276 to
1f9a3a2
Compare
SevereCloud
removed
the
pr-needs-work
inomdzhon
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Дизайн-ревьюОписание
Распилил Radio и Checkbox и добавил компонент SelectionControl для составления форм переключателей